bench: refactor to use string interpolation in mathjs#9602
Merged
kgryte merged 4 commits intostdlib-js:developfrom Jan 9, 2026
Merged
bench: refactor to use string interpolation in mathjs#9602kgryte merged 4 commits intostdlib-js:developfrom
kgryte merged 4 commits intostdlib-js:developfrom
Conversation
stdlib-bot
added
First-time Contributor
Contributor
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
kgryte
added
Benchmarks
kgryte
reviewed
Jan 9, 2026
kgryte
reviewed
Jan 9, 2026
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Jan 9, 2026
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Jan 9, 2026
kgryte
reviewed
Jan 9, 2026
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
approved these changes
Jan 9, 2026
Member
|
As the CI failure is not due to changes introduced in this PR, I'll go ahead and merge. |
Member
|
Thank you for your contribution and congratulations on your first PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #{{a part of #8647}}.
Description
Refactors the JavaScript benchmarks in docs/migration-guides/mathjs/benchmark/benchmark.subtract.js to replace string concatenation with @stdlib/string/format for benchmark names.
Improves readability, consistency, and allows future linting of benchmark names.
Related Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
@stdlib-js/reviewers